playlyfe / go-graphql

A powerful GraphQL server implementation for Golang
248 stars 20 forks source link

Improve Perf by using bytes #7

Open pyrossh opened 8 years ago

pyrossh commented 8 years ago

Its seems the graphql-go guys tested their library for performance and improved it by a factor of 30 by using bytes instead of string. So I checked the source and even we are using string which causes a lot of garbage collection it seems so I guess we also need to make the change later to seem how much perf we gain.

References: https://github.com/graphql-go/graphql/commit/065ab6bc628250881a59d36e3b1cee62f0baeb03 https://github.com/graphql-go/graphql/issues/119

We should take a look at this lib for improving the lexer, https://github.com/tdewolff/buffer