search

playlyfe / themis

A blazing fast JSON Schema v4 validator!
Other
60 stars 7 forks source link

Why Uglify? #14

Open moll opened 9 years ago

moll commented 9 years ago

Hey,

Why the dependency on UglifyJS? It's a build-minification tool. Wouldn't a plain eval be sufficient as you already do after piping everything through Uglify? Especially given that the default is to not compress the code. It would definitely be faster without involving Uglify, which I've got a feeling is to blame for the 300ms+ time spent compiling a single schema. ;-)

If people wish to compress the code as they see fit, dependency injection (a.k.a pass a function in) would be a decent solution.

atrniv commented 9 years ago

@moll , uglify was put to be able to create readable code for debugging purposes and also to remove any dead code that was generated. I will be removing it in a future release and leave it for the user to decide how he wants to compress or minify the generated validator.

moll commented 9 years ago

Great. Currently I think Themis has to be the slowest validator library evar because of that. Hundreds of milliseconds per Themis.validator call because of that. Awful awful. :)

jonasfj commented 9 years ago

Moving it to be an optionalDependency might be a good...

I see it as useful when compiling schemas upfront.. as one would be willing to pay for the cost... But if loading dynamically (even in a server) 300ms per schema is a lot of overhead (slow server startup isn't nice..).

johnrb2 commented 2 years ago

Is this project maintained anymore? The uglify dependency has a critical security error according to npm audit. Could we get it removed or updated? I can submit a pull request if that will help.