search

playpauseandstop / aiohttp-middlewares

Collection of useful middlewares for aiohttp.web applications.
http://aiohttp-middlewares.readthedocs.io
BSD 3-Clause "New" or "Revised" License
51 stars 6 forks source link

[Discussion] Error handling middleware expansion opportunity? #86

Open yuvalherziger opened 2 years ago

yuvalherziger commented 2 years ago

Hey @playpauseandstop, first off, I dig this project very much just by browsing the code and the docs - great work.

While I never tried using your library, I've stumbled upon it on aiohttp's third-party libraries list and it caught my attention. A few months ago, I started putting together a library I titled aiohttp-catcher, which fulfills a very similar purpose aiohttp-middlewares's error_middleware does. aiohttp-catcher does it a bit differently, but the general idea is similar and I trust its repo's README file is useful in understanding how it works. Alas, the library never took off as I haven't really advertised it too ambitiously and I've only been using it in a few apps I run for non-commercial purposes.

My question is this: would you be interested in joining forces and work together on porting some of the logic of aiohttp-catcher into aiohttp-middlewares's error_middleware? I'm more than willing to do the heavy lifting myself. That is, if the architecture of aiohttp-catcher makes sense to you. Happy to start a discussion one way or another.

P.S., I couldn't help but notice your location - I hope that you and your close ones are safe 🇺🇦 ❤️

playpauseandstop commented 2 years ago

Hi @yuvalherziger,

First of all thank for your warm words, I and all my close ones are safe now!

As of joining forces, I am intriguing for sure, as I know how hard is to promote own solutions, so let me briefly go through aiohttp-catcher and let you know if this join will be possible from my perspective.

I am not setting the exact ETA for my review, but expecting to complete it by EOW.

Thanks and talk to you soon!