search

playwright-community / eslint-plugin-playwright

ESLint plugin for Playwright
https://www.npmjs.com/package/eslint-plugin-playwright
MIT License
281 stars 39 forks source link

Fix prefer web first assertion rule #287

Closed An631 closed 7 months ago

An631 commented 7 months ago

Fixes the following issue:

286

I have also added new tests to verify this scenario.

An631 commented 7 months ago

@mskelton I see you have made most of the changes to this rule. Do you mind taking a looking whenever you have time? Thanks!

mskelton commented 7 months ago

Please fix the formatting errors with Prettier before submitting. I'll take a look once the formatting and linting is fixed.

An631 commented 7 months ago

@mskelton I have formatted the files with the command pnpm fmt. Although I did notice that prettier was also formatting two more files unrelated to my changes and I couldn't make prettier run without them. I figured it wouldn't harm anyone having those properly formatted as well in this PR so just kept them in there. Looks like the checks are passing now but please let me know if I missed something and thanks for taking a look.

An631 commented 7 months ago

@mskelton I have formatted the files with the command pnpm fmt. Although I did notice that prettier was also formatting two more files unrelated to my changes and I couldn't make prettier run without them. I figured it wouldn't harm anyone having those properly formatted as well in this PR so just kept them in there. Looks like the checks are passing now but please let me know if I missed something and thanks for taking a look.

mskelton commented 7 months ago

Thanks!

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: