search

playwright-community / playwright-go

Playwright for Go a browser automation library to control Chromium, Firefox and WebKit with a single API.
https://playwright-community.github.io/playwright-go/
MIT License
1.94k stars 144 forks source link

Use PLAYWRIGHT_NODEJS_PATH in `getNodeExecutable` #468

Closed carsonmeyer-wk closed 1 week ago

carsonmeyer-wk commented 2 weeks ago

In playwright-go v0.4400.0 some functionality was regressed with the PLAYWRIGHT_NODEJS_PATH env var as playwright.Run command no longer respects it. I have a fix for it but any suggestions to my changes are welcome. Thanks!

carsonmeyer-wk commented 1 week ago

@mxschmitt Could I get a release that has this PR in it?

mxschmitt commented 1 week ago

done.