search

plazi / GoldenGATE-Imagine

A GUI Tool For Freeing Text and Data from PDF Documents
Other
5 stars 0 forks source link

rename collectionCode to institutionCode #27

Open myrmoteras opened 2 years ago

myrmoteras commented 2 years ago

We would like to suggest to rename collectionCode as institutionCode (DWC term need to be checked), because almost all the collection codes are in fact institution codes.

see also

gsautter commented 2 years ago

The trouble with a general renaming is that we have the collectionCode annotation type in a ton of places (sort of a historically grown thing), so renaming it in the data is quite the endeavor ... the DwCAs have had the term corrected already, so it should be correct in GBIF and this for the matching service.

myrmoteras commented 2 years ago

As long as it is clear that GGI collectionCode is DWC institutionCode in our DWCA then this is ok, as we can see here

image from https://tb.plazi.org/GgServer/summary/C8083D6ADB684F11FF90B471FF88F55A and DWCA https://tb.plazi.org/GgServer/dwca/C8083D6ADB684F11FF90B471FF88F55A.zip

What is the plan to update the old documents? As part of the great batch?

gsautter commented 2 years ago

What is the plan to update the old documents? As part of the great batch?

DwCAs are re-packed on updates, so the batch will effect a DwCA update for every document it changes ... whatever rest remains I'll re-trigger manually (via the server console) afterwards.

gsautter commented 2 years ago

As long as it is clear that GGI collectionCode is DWC institutionCode in our DWCA then this is ok, as we can see here

Well, GGI will simply remain what we're used to for now ... might even gradually switch from the outside in, it's just too risky to make the change in one big go ... which is the exact reason we decided to change the DwCAs for starters.

myrmoteras commented 2 years ago

fine