Open pdatascience opened 7 years ago
@myrmoteras how to ping Guido on this issue? Can you please assigne to Guido? I am having problems with doing this. (probably not rights)
@gsautter can you look at this?
@pdatascience can you try to have one issue in one issue, which allows to close one after the other? Appreciated
@pdatascience can you assign now an issue to Guido?
@pdatascience can you try to have one issue in one issue, which allows to close one after the other? Appreciated
@myrmoteras don't get this :(
This is what Guido requested: all the changes needed (they need to be taken as a package as they denpend on each other) to fully integrate the new endpoint that Guido created in Sofia with TaxPub.
fine - it looks like many individual tasks to be solved. Between Guido and You
it's all one task: adapt the Enedpoint to TaxPub, there is little point in splitting in little tasks, i think Guido will understand
I do understand ;-)
And if there are multiple adjustments to be made to schema mapping, I'm perfectly happy to have that in one task.
The one thing I hate happening is a task re-opened with a pretty much new issue after the initial issue was resolved. That's because then you cannot close the task after resolving the original issue. Plus, such multi-issue tasks tend to grow pretty lengthy and become hard to overview. Plus, where would you put feedback for the solution of the original issue (in case there are problems) if the ticket has veered off to other issues?
@gsautter @myrmoteras I am happy to split up the task any way you like: these are my findings of what is needed to convert the output of the taxpub tagger as of now to make it validate :) cheers, vic
@teodorgeorgiev
Changes Needed to Convert Plazi-Returned XML into Validaning NLM XML
Add DTD
Insert the following line before
<article ...>
:materialsCitation
is not a valid tagInstead, use
tp:material-citation
and remove all attributes.OR
Use ` and remove all other attributes.
named-content
tags have only one attribute:content-type
Delete superflous attributes from
named-content
tags.E.g.
becomes
Similarly,
becomes
date
should not be used inside a material citation or outsidenamed-content
cannot be a child ofdate.
p
.Therefore,
becomes
date
is not a child of anything useful and will not be validated almost anywhere. Therefore, it should be used except as a child ofelement-citation
history
mixed-citation
product
related-article
related-object
tp:collecting-event
In that case it must follow the pattern
(((day?,month?)|season)?,year?,string-date?)
. This means that no punctuation ought to exist between the tokens!Therefore, in the text
becomes
Formatting tags such as
italic
andbold
must be removed from material citationsRemove those tags if you use
<tp:material-citation>
. You can keep them if you use<named-content content-type='material citation'>
quantity
does not existRemove
quantity
. E.g.becomes
history
does not existRemove
history
.content-type='institution'
should bedwc:institutionCode
As per DwC standard,
dwc:insitutionCode
is "The name (or acronym) in use by the institution having custody of the object(s) or information referred to in the record."So
should be
Similary
dwc:institutional_code
should not exist andshould be
Page breaks are foobared
Replace
with