plazi / arcadia-project

2 stars 1 forks source link

References in BLR: order #164

Open myrmoteras opened 3 years ago

myrmoteras commented 3 years ago

Should we consider to look into the order of the references provided in BLR? Right now the order is a bit odd

image

retog commented 3 years ago

They are sorted as strings rather than numbers Unfortunately I don't know where the code is, otherwise I could submit a PR.

gsautter commented 3 years ago

Just double-checked ... our upload component puts the references into the metadata exactly in the way they occur in the document. The sorting must be happening later, most likely on Zenodo.

Apart from that, it would be good to know which document and/or Zenodo deposition with is ... hard to test otherwise.

myrmoteras commented 3 years ago

sorry here is the paper https://zenodo.org/record/4544300#.YC2JlGhKj8A

FF84FFD2FF82FFE72055FFBE1762FF85

there is no UUID for it provided in BLR, but of course there is one. @gsautter shouldn't we add this too as we do for the other papers including treatments? Would at least make it easier to find it in TB!

FF84FFD2FF82FFE72055FFBE1762FF85

gsautter commented 3 years ago

Thanks, @myrmoteras the reason this deposition doesn't have a link bank to TB is that it doesn't contain any treatments, and so http://publication.plazi.org/id/FF84FFD2FF82FFE72055FFBE1762FF85 defaults to the search form because there is no article summary to show. Added the article LSID now, though (LSID wrapped UUID).

Looking at the JSON metadata at https://zenodo.org/record/4544300/export/json shows that the references are ordered correctly in there ... must be a display thing.

myrmoteras commented 3 years ago

so is this a question to @slint ?

gsautter commented 3 years ago

Would tend to think so, yes.

slint commented 3 years ago

Indeed it's an issue on our side, we apply alphanumerical sorting (I guess to follow publishing convention), but this doesn't work very well for "numbered-list"-formatted references... I've created an issue here https://github.com/zenodo/zenodo/issues/2116, I can schedule a quick-fix to be deployed early next week.

@gsautter no need to change anything on your side, as you mentioned the submitted JSON order is correct :)