plazi / community

This repo is intended to serve as a help desk for TreatmentBank-users.
6 stars 1 forks source link

on 2022-12-14 , Kendra claimed that [ Barbastello leucomelas ] should be replace with [ Barbastella leucomelas ] in [ cut:zip:hash://sha256/56caf9620cd58df6fb517dfb7cd01e2e81e54a41eef2f562c5eddfbd70ba6197!/treatments-xml-main/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml!/b3714-3735 ] #192

Closed jhpoelen closed 1 year ago

jhpoelen commented 1 year ago

on 2022-12-14 , Kendra claimed that [ Barbastello leucomelas ] should be replace with [ Barbastella leucomelas ] in [ cut:zip:hash://sha256/56caf9620cd58df6fb517dfb7cd01e2e81e54a41eef2f562c5eddfbd70ba6197!/treatments-xml-main/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml!/b3714-3735 ]

valdenar commented 1 year ago

Hi @jhpoelen I corrected the taxonName and then it must be updated in the Treatment Bank thanks for your review

Valdenar

jhpoelen commented 1 year ago

Note that in a recent copy of Plazi treatment xml, I still found the referenced text Barbastello leucomelas , so I was unable to verify that this issue was addressed.

However, related issues #189 and #190 appear to have been resolved.

flsimoes commented 1 year ago

I believe this one is resolved now (at least from what I can see)

jhpoelen commented 1 year ago

@flsimoes great! What do you think would be a good way for me to verify that the issue has been fixed? How do you see that the issue has been fixed?

flsimoes commented 1 year ago

@jhpoelen as I mentioned before, I either see it through the XML or HTML, or through the stats pages, such as in this query: https://tb.plazi.org/GgServer/srsStats/stats?outputFields=tax.genusEpithet+tax.speciesEpithet&groupingFields=tax.genusEpithet+tax.speciesEpithet&orderingFields=tax.genusEpithet&FP-tax.genusEpithet=%25Barb%25&FP-tax.speciesEpithet=leucomelas&format=HTML

The query shows no other register of "Barbastello" attached with "leucomelas".

Or even this one, which shows there's no "Barbastello" at all in TreatmentBank now https://tb.plazi.org/GgServer/srsStats/stats?outputFields=tax.genusEpithet+tax.speciesEpithet&groupingFields=tax.genusEpithet+tax.speciesEpithet&orderingFields=tax.genusEpithet&FP-tax.genusEpithet=%25Barbastello%25&format=HTML

Treatment XML: https://tb.plazi.org/GgServer/xml/C30587A9A562FF93FF2F350F875ED55F

myrmoteras commented 1 year ago

@jhpoelen look at:

  1. the html in TB
  2. the XML in TB
  3. look at the html and look at the version whether it has changed recently
  4. the XML metadata and check whether there is a newer version
  5. if you go it the treatment-xml check in the treatment-xml github repo- it should be there within 10 minutes or so.
  6. look at TB stats and look whether the upload for the treatment has changed recently
jhpoelen commented 1 year ago

@flsimoes @myrmoteras thanks again for being patient.

I imagine it must be annoying to have this guy from Minnesota asking the same question over and over again: what is the reference for your claim that Barbastello leucomelas has been replaced with Barbastella leucomelas as they relate to Kendra's claims?

In the most recent version of the affected treatment, I still detect many instances of "Barbastello" and "Barbastello leucomelas"

Namely at:

https://github.com/plazi/treatments-xml/blob/420c42317d6548797245c70e893c3cee54f39165/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml#L58

and

https://github.com/plazi/treatments-xml/blob/420c42317d6548797245c70e893c3cee54f39165/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml#L52

and

https://github.com/plazi/treatments-xml/blob/420c42317d6548797245c70e893c3cee54f39165/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml#L104

and

https://github.com/plazi/treatments-xml/blob/420c42317d6548797245c70e893c3cee54f39165/data/C3/05/87/C30587A9A562FF93FF2F350F875ED55F.xml#L106

See also attached screenshots.

image

image

myrmoteras commented 1 year ago

the fact, not a claim so now you speak a language that we understand. Now you talk about an attribute, not a taxonomic name as before. If you would have told this at begin then it would have been fixed.

flsimoes commented 1 year ago

So we are talking about the treatmentCitation then, I'll have a look

flsimoes commented 1 year ago

So, the remaining Barbastello will soon disappear

jhpoelen commented 1 year ago

@flsimoes thanks for checking.

Note that https://github.com/jhpoelen/msw-plazi/issues/4 captures a data source that is a little closer to the treatmentbank source of truth. I hope that by switching from treatments-xml github to tracking treatmentbank directly, these synchronization issues are no longer a concern for this msw-plazi workflow.

jhpoelen commented 1 year ago

@flsimoes sorry to bother you again, but do you happen to know how I can download, most efficiently, all treatment xmls from treatment bank? I don't see any data download options, and I am sure that I am missing something.

jhpoelen commented 1 year ago

related to https://github.com/jhpoelen/msw-plazi/issues/4 .