plazi / treatmentBank

Repository devoted to house keeping of treatmentBank
0 stars 0 forks source link

wrong higher categories on Pensoft articles: how to deal with it #29

Closed myrmoteras closed 2 years ago

myrmoteras commented 2 years ago

@gsautter if we encounter wrong higher categories in Pensoft sourced journals, how to deal with this? see eg https://github.com/plazi/community/issues/136

  1. If we notify Pensoft and they fix it, will this also be transferred to us?
  2. If not, then we have to do it on our end.
myrmoteras commented 2 years ago

Looking at the pensoft XML, we are introducing them. so we need not only to correct this, but also have a policy how we add these attributes

gsautter commented 2 years ago

Right now, we take the higher taxa from the Pensoft TaxPub documents as what they are, simply assuming they are correct ... the idea is to not diverge from the original publication, but represent it as accurate as possible ... should we design a different approach?

lyubomirpenev commented 2 years ago

@t.georgiev please check the issue and report back. I believe you take the higher classification from our article-level metadata?

On 1/31/2022 2:37 PM, Guido Sautter wrote:

Right now, we take the higher taxa from the Pensoft TaxPub documents as what they are, simply assuming they are correct ... the idea is to not diverge from the original publication, but represent it as accurate as possible ... should we design a different approach?

— Reply to this email directly, view it on GitHub https://github.com/plazi/treatmentBank/issues/29#issuecomment-1025696500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDFNGJVVQ64FYQ2QGTVRI3UYZ67ZANCNFSM5NAU4G2Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Prof. Dr. Lyubomir Penev CEO and Founder Pensoft Publishers http://www.pensoft.net ARPHA Publishing Platform http://www.arphahub.com 12 Prof. Georgi Zlatarski Street 1700 Sofia, Bulgaria Tel +359-2-8704281 Fax +359-2-8704282 ORCID ID: http://orcid.org/0000-0002-2186-5033 Journals: http://www.pensoft.net/journals Publishing services for journals: http://www.pensoft.net/services-for-journals Books published by Pensoft: http://www.pensoft.net/books-published-by-Pensoft Services for scientific projects: http://www.pensoft.net/projects Find us on: Facebook http://www.facebook.com/pages/Pensoft-Publishers/170816832934216?ref=ts, Google+ https://plus.google.com/u/0/b/114819936210826038991/114819936210826038991/posts, Twitter https://twitter.com/#%21/Pensoft

myrmoteras commented 2 years ago

this is what we have in TB from https://zookeys.pensoft.net/article/78233/ image

<taxonomicName id="61E2AFA59755A493ECAB7982134B81E5" LSID="http://zoobank.org/A2EF195A-A19C-43CD-A774-A06218E96EE9" authority="sp. nov." authorityName="sp. nov." class="Mammalia" family="Soricidae" genus="Chodsigoa" higherTaxonomySource="CoL" kingdom="Animalia" lsidName="Chodsigoa dabieshanensis" order="Eulipotyphla" pageId="0" pageNumber="129" phylum="Chordata" rank="species" species="dabieshanensis">Chodsigoa dabieshanensis sp. nov.</taxonomicName>

https://tb.plazi.org/GgServer/xml/AFACD42EDC6C56578612A6C37DF62B8B

https://tb.plazi.org/GgServer/html/AFACD42EDC6C56578612A6C37DF62B8B

and that is what's in Zookeys

`

AFACD42E-DC6C-5657-8612-A6C37DF62B8B Chodsigoa dabieshanensis http://zoobank.org/A2EF195A-A19C-43CD-A774-A06218E96EE9 ` and ` Chordata Mammalia Soricidae Vertebrata ` How does the higher categories get attributes in Plazi `` ? What to do if there are errors or missing higher categories?
gsautter commented 2 years ago

For treatment taxa, the importer also considers the higher taxa given in the tp:treatment-meta/kwd-group element ... here the source TaxPub (https://zookeys.pensoft.net/article/78233/download/xml/): image

The authority is most definitely wrong ... and the higher taxa in the TreatmentBank XML match the ones givem in the TaxPub.

myrmoteras commented 2 years ago

in this case, where does the phylum and class originate?

gsautter commented 2 years ago

in this case, where does the phylum and class originate?

Filled in from CoL and GBIF ... but existing higher taxa aren't replaced with these lookup results.

To ask the other way around: which higher taxa are wrong, exactly? If it's class and phylum, that's for me to investigate, but if it's others, the source TaxPub is the origin of those ...

teodorgeorgiev commented 2 years ago

It seems OK to me ... what exactly is wrong?

image

gsautter commented 2 years ago

@teodorgeorgiev <tp:taxon-authority>sp. nov.</tp:taxon-authority> doesn't really look right to me ... it's a status label, not an authority, is it?

teodorgeorgiev commented 2 years ago

Yes, the authority is wrong ... but I did not get what is wrong with the higher taxa

gsautter commented 2 years ago

Guess I'll have to check the higher taxa, then ... TB adds class and phylum to complete the higher taxa, so there might have been a mishap there.

teodorgeorgiev commented 2 years ago

it is corrected to sp. nov.</tp:taxon-status> ...

gsautter commented 2 years ago

it is corrected to tp:taxon-status>sp. nov.</tp:taxon-status> ...

OK, thanks, will re-import it asap.

myrmoteras commented 2 years ago

@teodorgeorgiev we fixed it- that's why there is not nothing wrong.

teodorgeorgiev commented 2 years ago

@gsautter @myrmoteras Thanks! I appreciate really that. Is there a problem with the higher categories or it was only the wrong authority?

gsautter commented 2 years ago

@teodorgeorgiev reading the above, seems as though the higher taxa might have been phylum and class only (added on our end), which @myrmoteras said was corrected, so the authority would have been the only error in the source TaxPub proper.

teodorgeorgiev commented 2 years ago

@gsautter all clear now, 10x!