search

plazi / treatmentBank

Repository devoted to house keeping of treatmentBank
0 stars 0 forks source link

twice authority name and authoriry #50

Closed myrmoteras closed 1 year ago

myrmoteras commented 2 years ago

@gsautter in this case, both the authority name and authority are showing up. I can't fix it, and I also buffled why this occurs in two articles image

https://tb.plazi.org/GgServer/html/CF87EFC9FF6A594CA0FCB2CD2ED36A72

https://tb.plazi.org/GgServer/html/D82E8784FFD579722ADAFE17FBCBD327?cacheControl=force

2417FFFCFFD179772A69FFEEFFCAD673 FFC8FFF7FF8EFFFE9F6EFFEEFFFF3860

flsimoes commented 2 years ago

The issue is caused by the author name being part of the taxonomicName. Splitting it solves the problem, which does occur throughout the text.

Fix for S. agnoston as an example: image image

image image

gsautter commented 2 years ago

This might simply be a rendering issue ... will look into the XSLT that produces the treatment pages.

gsautter commented 2 years ago

This might simply be a rendering issue ... will look into the XSLT that produces the treatment pages.

That said, no need to split authorities off names ... they should be included ... just need to render them properly.

gsautter commented 2 years ago

Turns out the XSLT is actually fine ... it actually does check if the taxon name string contains the authority, and if so, doesn't add it ... only in this treatment, it's S.Knapp in the text vs. S. Knapp in the attribute, so this was as simple as a spacing issue ... if you look closely, you can even see that in the screenshot above.

Still have to add the year, though, as that isn't given in the text, so I'll need to adjust the XSLT after all ...

gsautter commented 2 years ago

Changed the XSLT now so it also adds the year from the authorityYear attribute if it isn't given in the text.