search

plcpeople / nodeS7

Node.JS library for communication to Siemens S7 PLCs
MIT License
356 stars 120 forks source link

Prevents parser errors from crashing the process #108

Closed gfcittolin closed 4 years ago

gfcittolin commented 4 years ago

As seen on #107, parser errors can cause the whole process to crash, as the code path is being triggered by an incoming network packet. Such errors should be handled as stream error events instead

flacohenao commented 4 years ago

I think it is actually happen... did you test you laste commit?

gfcittolin commented 4 years ago

Did the very bad thing to do a change after testing. My bad :facepalm: Fixed on c25286d4fc25290c686ab92919a2377b99dcb0aa