search

plcrodrigues / RPA

Python code for the Riemannian Procrustes Analysis (RPA) method
BSD 3-Clause "New" or "Revised" License
47 stars 19 forks source link

Old dependencies/requirements #2

Open moonj94 opened 3 years ago

moonj94 commented 3 years ago

Thanks for publishing your code I am sure they will be very helpful.

I was wondering if you are ever planning on updating the code so that later versions of e.g. numpy are compatible? I ask because the rest of my code for my BCI pipeline require certain recent dependencies for things like MNE. It would be very helpful if an updated version of the code could be published with more recent dependencies.

Thanks!

plcrodrigues commented 3 years ago

Hi @moonj94, thank you very much for your message. Indeed, the code needed some cleaning up and the requirements were quite old. I have just done some modifications and pushed them into the master branch. I hope it suits your needs :-) Cheers, Pedro

moonj94 commented 3 years ago

wow @plcrodrigues thanks so much for updating the code, and on such short notice! Do you know if those exact requirements must be met?

The reason I ask is because my code is stable with: numpy=1.19.2 scipy=1.16.0 joblib=1.0.0

plcrodrigues commented 3 years ago

Hi, the numpy and scipy parts are definetly compatible. I've just made a small test with joblib on 1.0.1 and it works OK as well. I would think you should not have any headaches. Let me know if it is not the case !