Closed farhanpapin closed 3 years ago
farhanpapin
commented
3 years ago @lazyparser I am trying to add support for a new instruction in the RISCV ZCE extension, I am not able to see the details of the one failing test. could you kindly guide on how I can resolve this?
lazyparser
commented
3 years ago @lazyparser I am trying to add support for a new instruction in the RISCV ZCE extension, I am not able to see the details of the one failing test. could you kindly guide on how I can resolve this?
Hi @farhanpapin
Thanks for contributing! The log is here: https://llvm.ngrok.io/logs/28-run-2021-10-20T16:23:24.617Z.log
The build steps can be found here: https://github.com/plctlab/github-ci-for-llvm/blob/master/Dockerfile
and @ChunyuLiao may provide more details on the error messages.
farhanpapin
commented
3 years ago @ChunyuLiao My pass does not touch Load/Store instructions. Any insights on this ?
ChunyuLiao
commented
3 years ago @farhanpapin You can try this patch to fix ci.
At the same time， you should add test case for this patch
diff --git a/llvm/lib/Target/RISCV/RISCVDecBNEZ.cpp b/llvm/lib/Target/RISCV/RISCVDecBNEZ.cpp
index 50095071a0a2..a43a422f5143 100644
--- a/llvm/lib/Target/RISCV/RISCVDecBNEZ.cpp
+++ b/llvm/lib/Target/RISCV/RISCVDecBNEZ.cpp
@@ -33,9 +33,11 @@
#include "RISCVSubtarget.h"
#include "llvm/CodeGen/MachineBasicBlock.h"
#include "llvm/CodeGen/MachineInstrBuilder.h"
+#include "llvm/Support/Debug.h"
using namespace llvm;
+#define DEBUG_TYPE "riscv-decbnez"
#define RISCV_DECBNEZ_NAME "RISCVDecbnez"
namespace {
@@ -71,7 +73,7 @@ bool RISCVDecbnez::runOnMachineFunction(MachineFunction &MF) {
bool Modified = false;
if (!STI->hasStdExtZce()){
- dbgs() << "no hasStdExtZce. returning \n";
+ LLVM_DEBUG(dbgs() << "no hasStdExtZce. returning \n");
return Modified;
}@ChunyuLiao I am a bit flustered on this. What is the permission denied error?
[llvm-debug-test 1/1] RUN ninja check:
executor failed running [/bin/sh -c ninja check]: exit code: 1
ChunyuLiao
commented
3 years ago the permission denied error, I think is CI's environmental problem. My result: Testing Time: 387.57s Unsupported : 18707 Passed : 52405 Expectedly Failed: 85
so merge this patch.
added support for the decrement branch not equal zero instruction