search

pldn / LDWizard

🧙 LDWizard: A generic framework for simplifying the creation of linked data. Supported by the PLDN community.
European Union Public License 1.2
13 stars 7 forks source link

#26 URL validation added for input fields #112

Closed philipperenzen closed 1 year ago

philipperenzen commented 1 year ago

LDWizard should now inform the user when an invalid URL as input is provided.

philipperenzen commented 1 year ago

closes #26

RossCurry commented 1 year ago

Hey, I tested out your code and these are my comments: testing:

  1. As soon as I load a CSV file, I am greeted with an error about how my IRI is invalid, even though it should not be. As soon as I make a change in the field the error message goes away. Seems to be with the placeholder/default value.
  2. I have the same issue when I click on the advanced drop down. The placeholder is a valid URL/iri but it complains that it is an error.
  3. I think the helper text would suffice to be simply 'Invalid URL'. You already have the URL being displayed in the text input.
  4. Next button works even with an Invalid URL. This should probably be disabled until the URL is valid.
  5. Once I have loaded in the data. Clicking on a column header brings up a modal menu with an autosuggest. If I click outside of that autocomplete to close it, the empty field complains about " being an invalid URL. I think if we haven't touced the field and it is empty, that shouldn't be an Invalid URL message, but a field/value requiered message.
RossCurry commented 1 year ago

Also, as we've discovered, lets add yarnPath: .yarn/releases/yarn-1.22.19.cjs to the .yarnrc.yml file. It seems to solve the inconsistencies we've been having between some people being able to build while others cannot.