Code reuse: Vocabulary Recommender library

pldn / LDWizard

🧙 LDWizard: A generic framework for simplifying the creation of linked data. Supported by the PLDN community.

European Union Public License 1.2

12 stars 7 forks source link

Code reuse: Vocabulary Recommender library #95

Open wouterbeek opened 1 year ago

wouterbeek commented 1 year ago

[Who] As a developer of LD Wizard,
[What] I would like to reuse the Vocabulary Recommender library,
[Why] So that I can reuse external code i.o. maintain custom internal code.

Background

Clariah maintains an open source Vocabulary Recommender library: https://github.com/CLARIAH/vocabulary-recommender
This external library provides vocabulary recommendations that are similar to the recommendations that are given inside LD Wizard.

Acceptance criteria

Old internal code for giving vocabulary recommendations is removed.
The external Vocabulary Recommender library to be used instead to provide the same functionality as before.

EnnoMeijers commented 1 year ago

This sounds like a very nice improvement! I see one possible point of complexity which might needs some attention. The current selection of source vocabularies is part of the specific configuration of a LDWizard variant. This should be the preferred way of implementation for the Vocabulary Recommender too, in that way variants can choose their own preferred vocabularies. So the new Vocabulary Recommender also need an interface into the config.ts of the LDWizard variant.

rlzijdeman commented 1 year ago

Hi, I the Vocab Recommender uses an endpoint as input for which vocabularies to recommend. So anyone can provide or create an endpoint with their specific vocabs. In order to use the network of terms, we would need to create a sparql endpoint with the NoT vocabs.

GerwinBosch commented 5 months ago

@wouterbeek is this a duplicate of #97?