search

pldubouilh / gossa

🎶 a fast and simple multimedia fileserver
MIT License
913 stars 72 forks source link

Upload shortcut does not work #109

Closed kovmir closed 3 months ago

kovmir commented 8 months ago

I use gossa tag v1.0.0. My setup is dwm and librewolf. Nothing happens if I hit Ctrl + U, file picker does not appear. However, file picker works if I click the upload icon.

Also, do not hide the upload icon on desktop, please!

kovmir commented 3 months ago

<input> picker was blocked due to lack of user activation. is what I get in console each time I hit ctrl+u. Possible fix here.

pldubouilh commented 3 months ago

Ah right, that's an issue I saw in the past indeed, it's a limitation from the browser, where a user interaction is required in order to be able to catch keyboard actions. The fix mentioned feels like a bug in Firefox though 🫠
I'll close this up for the time being :+1:

pldubouilh commented 3 months ago

Also, do not hide the upload icon on desktop, please!

@kovmir regarding this, I think I'll allow custom JS to be injected from the CLI in a future release. Also it'll help with #110, etc...

kovmir commented 3 months ago

Why do you not want to include this natively? Unlike the keyboard shortcut, it works every time.