add mkv as an allowed video type, fixes #94

pldubouilh / gossa

🎶 a fast and simple multimedia fileserver

MIT License

874 stars 73 forks source link

add mkv as an allowed video type, fixes #94 #110

Open jkaberg opened 4 months ago

jkaberg commented 4 months ago

this fixes #94

also please deploy an new container version while at it 😄

pldubouilh commented 2 months ago

Hi, thanks for the PR, and sorry for the slow reply ! I prefer to wait a bit before merging this - support is not super widespread yet, and depending on the codec it can end up in a black screen with no video starting :( I actually implemented forced-download for MKVs after someone reported this very behaviour. Let's keep an eye on support, and merge this when support lands more broadly :+1:

TakeoIschiFan commented 2 weeks ago

How about adding a "enable experimental video player features" cli flag, off by default, that enables playback for mkv?

Would not impact most users as it is disabled by default, but the feature is still there for those that want it.