pldubouilh / gossa

🎶 a fast and simple multimedia fileserver
MIT License
874 stars 73 forks source link

[Pull request] Backend rewrite and many improvements #68

Open ViRb3 opened 3 years ago

ViRb3 commented 3 years ago

Hello! I love this project and I have been using it for a long time, but after looking at the code, I noticed multiple problems. I ended up rewriting the whole backend and I think it works much better now. My rewrite is fully backwards-compatible with your project.

You can find my rewrite here: https://github.com/ViRb3/gosses If you are interested, I would be happy to merge all my changes into this project.

Here are the major changes:

Thanks!

pldubouilh commented 3 years ago

Hey ! Thanks a lot for this :) Sorry for the slow reply, been busy these past few weeks, but I'll review that soon !

pldubouilh commented 2 years ago

hey - sorry for the slow turnout ! So I ended up pulling a lot of changes from your branch :+1:

I didn't bring over the server & logging, to remain dependency-free. I'll think of maybe logging in Common Log Format at some point, so it's easy to mangle into another format through third party tool.

Also I managed to get reproducible builds ! (manage is a large statement for adding a single -trimpath to the build haha :) so I thought auto-release became less necessary - I cut a release or two a year, and it'd be trivial to compare the hashes to see that nothing nefarious happened from my end.

I co-authored you on the commits I pulled from your branch - feel free to keep me posted what you think of the changes, it's on PR #72. Thanks ! :)