search

pldubouilh / gossa

🎶 a fast and simple multimedia fileserver
MIT License
874 stars 73 forks source link

Dangerous -ro flag #93

Closed SeanRamey closed 1 year ago

SeanRamey commented 1 year ago

Could you make it so that when you start gossa, it tells you if read-only mode is enabled or disabled? I've learned that read-only is not enabled if you add -ro after the root file directory path, and this could cause somebody to accidentally allow write access.

Either making it so that it doesn't matter where you give the -ro flag, or giving a warning message about whether or not read-only is enabled or disabled would fix the issue.

pldubouilh commented 1 year ago

Hey - thanks for the feedback :+1: I added both a log message for the options, and also made it impossible to startup if there are more than one trailing argument (the target folder)

SeanRamey commented 1 year ago

Nice! Thank you!