search

plebbit / plebbit-js

A Javascript API to build applications using plebbit
GNU General Public License v2.0
41 stars 7 forks source link

fix ActiveUserCount calculation #15

Closed plebeius-eth closed 1 year ago

plebeius-eth commented 1 year ago

allActiveUserCount is still zero after more accounts posted, so i guess it's bugged. useSubplebbitStats is not showing errors and its state is succeeded. I see it works for all other subs, however the count is very low all of them, so maybe there's something wrong about the calculation. the posts:users ratio seems off, it's like it takes too many posts of different users to count 1 user

After almost 10 different accounts posted in p/plebtoken.eth, allActiveUserCount increased from 0 to only 1. If I only look at the OP posts, it's 4 different acconts. This ratio is similar across all communities.

In my opinion, this issue's priority is tied to the core value of the plebbit project: full community ownership. The member count can directly influence the value of the sub, so it should also influence the value of its ENS name, if set.

Rinse12 commented 1 year ago

Should be fixed with commit c5e9662e0d01b1f7347e7671a5397e074a7e8f0d

To clarify: User count = # of unique author addresses who published a vote or comment or post Post count = # of unique author addresses who published posts