search

plebbit / plebbit-js

A Javascript API to build applications using plebbit
GNU General Public License v2.0
41 stars 7 forks source link

make sure both import Plebbit from '@plebbit/plebbit-js' and import {getShortAddress} from '@plebbit/plebbit-js' work #37

Closed estebanabaroa closed 8 months ago

estebanabaroa commented 8 months ago

make sure both import Plebbit from '@plebbit/plebbit-js' and import {getShortAddress} from '@plebbit/plebbit-js' work

all Plebbit static functions should also be exported separately so that both of these work:

{getShortAddress} from '@plebbit/plebbit-js'

and 

Plebbit from '@plebbit/plebbit-js' 
Plebbit.getShortAddress()
Rinse12 commented 8 months ago

Sounds good. What about getShortCid, nativeFunctions, setNativeFunction, challenges?

estebanabaroa commented 8 months ago

Sounds good. What about getShortCid, nativeFunctions, setNativeFunction, challenges?

yes I would export all static properties, it seems to be standard in libraries

Rinse12 commented 8 months ago

Done with commit a9611fc376a395068023b6edbd03506d66da6b37