search

plebbit / plebbit-js

A Javascript API to build applications using plebbit
GNU General Public License v2.0
41 stars 7 forks source link

implement plebbitOptions.userAgent #43

Closed estebanabaroa closed 2 months ago

estebanabaroa commented 4 months ago

which would override the userAgent in pubsub.

would be nice to have in the subplebbit uptime monitor

Rinse12 commented 4 months ago

Good idea, so after initializing, the Plebbit instance is gonna have a plebbit.userAgent field that defaults to /plebbit-js:${plebbitJsVersion}/?

estebanabaroa commented 4 months ago

Good idea, so after initializing, the Plebbit instance is gonna have a plebbit.userAgent field that defaults to /plebbit-js:${plebbitJsVersion}/?

do we need it to be public? it could just be part of plebbitOptions and not part of the plebbit instance

Rinse12 commented 2 months ago

I guess it should because other plebbit options are public as well?

estebanabaroa commented 2 months ago

I guess it should because other plebbit options are public as well?

PlebbitOptions is not documented on the Plebbit instance in the readme, and not sure they are being used anywhere in the hooks. I think we should leave them private and undocumented for now until we actually need them.

Rinse12 commented 2 months ago

Implemented