search

plebbit / plebbit-react

A GUI for plebbit
https://plebbitapp.eth.limo
GNU General Public License v2.0
35 stars 6 forks source link

Migrate to new PlebbitOptions #249

Closed estebanabaroa closed 1 year ago

estebanabaroa commented 1 year ago

From this plebbit-react-hooks version, the PlebbitOptions have changed https://github.com/plebbit/plebbit-react-hooks/commit/33fca8ef1cfc78e5c16d7fcbe7effbeebeb082c8

You can view them here https://github.com/plebbit/plebbit-js#plebbitplebbitoptions

ipfsGatewayUrl -> ipfsGatewayUrls ipfsHttpClientOptions -> ipfsHttpClientsOptions pubsubHttpClientOptions -> pubsubHttpClientsOptions

ChainProvider also changed https://github.com/plebbit/plebbit-js#chainprovider

ChainProvider.url -> ChainProvider.urls

All the values are now string[] instead of just a string so this will need to be changed in the settings plebbit options page to allow the user to put an array of strings.

I think this change is required before the next release or the user won't be able to edit their plebbit options properly.

estebanabaroa commented 1 year ago

In https://plebbitapp.eth.limo/#/settings/plebbit-options

the words "Url" should be replaced by "URLs" and the words "Client" by "Clients"

(including in the chainProvider.urls option)