Open plebeius-eth opened 8 months ago
0077df01a125c885cddbf136aa9446948ca082c4
you should rename NewPosts with NewerPosts everywhere.
NewPosts is not accurate, it will only trigger if there are newer posts than the ones displayed. It won't trigger if there are new posts that are older than the ones displayed in the loaded feed.
I had originally said to have a component
fixed eb91de7c434317d6f11750192c23c2839f16718f
design looks bad I think, I dont like the X, the green color or the font. I guess it should look more like one of the native reddit button. maybe just
also the button isn't centered properly in the feed, and has weird behavior when it scrolls. why not just use floating-ui like the ChallengesModal component.
by the way the UI can say "new posts", just the variable names should say "newer" posts because it's more technically accurate. but the UI probably looks weird with "newer"
replied on tg https://t.me/seeditreact/6762
8952f42540027d9d4f8cb23c3fd93b19ceb93c8f
that looks awful, it's not centered, it looks randomly placed. also even if it were centered, the design looks terrible, it doesn't look like it's floating, it merges with the background and you can't see it well. also the [x] is a different size, so it looks out of place.
also the scrolling is laggy and not smooth, it's really awful in every aspect.
imo we should remove this altogether from production until we can make it looks good, and not sure we we can make it look good at the moment.
I guess it should probably be integrated into the grey top bar or the blue account bar, maybe we remove or push some item to the right in the top bar when there are new posts. I cannot imagine a way to make it look good as some floating button.
maybe we could place it where the get new reddit button is with a similar design? and when the user scrolls up, it merges with the grey bar, and when the user clicks X, it disappears?
If there's no good way to make it merge with the top bar on scroll up, then whenever there's newer posts, it would mean we would have to fix the top bar permanently until the user presses X on the newer posts button I guess.
This is pretty low priority and not sure it's that useful, and it will be hard to get right I think, might be better to abandon it for now
maybe something like this would be OK
the button could merge with the top bar when the user scrolls up
even then, it still looks kind of bad, we should probably just abandon it for now