search

plebbit / seedit

A GUI for plebbit similar to old.reddit
https://seedit.eth.limo/#/
GNU General Public License v2.0
11 stars 2 forks source link

use query string for context route #284

Closed plebeius-eth closed 7 months ago

plebeius-eth commented 7 months ago

p/<sub>/c/<cid> is part of the protocol, the /context isn't so ideally we would have a way to do it without adding unnecessary endpoints to the protocol Im actually not a fan of using /context endpoint at all cause it wont work on other clients maybe it should be ?context=1 or something this way those links will work in any client and the previewer could potentially pass query string like ?context=1 to the app this will make the links work on all clients, but the seedit client specifically can check the context query string and do something extra cause p/<sub>/c/<cid>/context will 404 on plebchan and plebones which isnt cool but p/<sub>/c/<cid>?context=1 will work on all clients

plebeius-eth commented 7 months ago

6516245abfd2a0a02ac49628873265b7c9b5c0a3

plebeius-eth commented 7 months ago

https://t.me/seeditreact/5639

plebeius-eth commented 7 months ago

b9d050c87c45b2e1c541a4ac45e7f23b6e5490f7

estebanabaroa commented 7 months ago

Im still seeing context=1, shouldnt it be context=3 like on reddit?

plebeius-eth commented 7 months ago

yes I forgot, changed it to 3 now 29891a6e39f7c7dd5f6e930f7f7f041126565fde