plebbit / seedit

A GUI for plebbit similar to old.reddit
https://seedit.eth.limo/#/
GNU General Public License v2.0
11 stars 2 forks source link

add 'loading comments' string in post view, hide reply form before comment is loaded #285

Closed plebeius-eth closed 4 months ago

plebeius-eth commented 7 months ago

I think “all comments” should say “loading comments…”

not a bad idea, maybe with the ellipsis animation

Esteban Abaroa, [Mar 4, 2024 at 9:22:30 PM]: you might want to remove the comment box before the comment is loaded, but keep it while the comment update is loading imo its confusing to see the empty values with the comment box

plebeius-eth commented 7 months ago

a06869196d236f51ab8bfffae46bdf08aefd95df

estebanabaroa commented 7 months ago

I don't really like the fact that it shows "loading comments..." before the post data is loaded. maybe before the post data is loaded, we just hide the entire comment section, "all comments", "sort by", etc

then maybe once the post data is loaded (post.timestamp is defined), show the "loading comments..."

also the location of the state string is ugly imo: image

also another issue is that it is possible to comment before the comments load, so why remove the comment box. as soon post.subplebbitAddress and post.cid are defined, it's possible to write a comment.

plebeius-eth commented 6 months ago

fixed: e276763a3d0370242ae20d2a04ae17d0f5ddccb5

estebanabaroa commented 6 months ago

no loading string before comment is loaded image

estebanabaroa commented 6 months ago

also I think I would remove the ellipsis animation from loading comments... it looks bad to have 2 ellipsis animations at once.

plebeius-eth commented 6 months ago

e1a3745af9e4b160acdf8d0d557ccf2f694038c8

estebanabaroa commented 6 months ago

there's a big empty space before the state string and

also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk

image

plebeius-eth commented 4 months ago

there's a big empty space before the state string and

also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk

should be fixed now f40665dc5cec28cdc859c5dc1f83f1aa6adecb1c

estebanabaroa commented 4 months ago

I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.

plebeius-eth commented 4 months ago

I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.

yes that's better, fixed it b84e0fcba1f4539c4298774905822dac96b449e0