Closed plebeius-eth closed 4 months ago
a06869196d236f51ab8bfffae46bdf08aefd95df
I don't really like the fact that it shows "loading comments..." before the post data is loaded. maybe before the post data is loaded, we just hide the entire comment section, "all comments", "sort by", etc
then maybe once the post data is loaded (post.timestamp is defined), show the "loading comments..."
also the location of the state string is ugly imo:
also another issue is that it is possible to comment before the comments load, so why remove the comment box. as soon post.subplebbitAddress and post.cid are defined, it's possible to write a comment.
fixed: e276763a3d0370242ae20d2a04ae17d0f5ddccb5
no loading string before comment is loaded
also I think I would remove the ellipsis animation from loading comments... it looks bad to have 2 ellipsis animations at once.
e1a3745af9e4b160acdf8d0d557ccf2f694038c8
there's a big empty space before the state string and
also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk
there's a big empty space before the state string and
also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk
should be fixed now f40665dc5cec28cdc859c5dc1f83f1aa6adecb1c
I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.
I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.
yes that's better, fixed it b84e0fcba1f4539c4298774905822dac96b449e0