plebbit / seedit

A GUI for plebbit similar to old.reddit
https://seedit.eth.limo/#/
GNU General Public License v2.0
11 stars 2 forks source link

implement subplebbit.features for media in subplebbit settings and publishing forms #301

Open plebeius-eth opened 7 months ago

plebeius-eth commented 7 months ago

subplebbit edit pics-art.sol --features.requirePostLinkIsMedia true

plebeius-eth commented 7 months ago

should be a new setting group in SubplebbitSettings, called Features

plebeius-eth commented 7 months ago

this issue should only be for a media feature setting for now, I guess just features.requirePostLinkIsMedia and features.noVideos

Rinse, [Mar 13, 2024 at 10:18:12 AM]: features.noVideos is not implemented yet

Tom (plebeius.eth), [Mar 13, 2024 at 10:20:47 AM]: I'm also checking media types so the front end can throw the error for now, if the boolean is defined

should add this media format check in submit page and reply form, to prevent users posting videos in a r/pics sub (if features.noVideos is true)

plebeius-eth commented 7 months ago

Esteban Abaroa, [Mar 13, 2024 at 2:48:49 PM]: you should not implement stuff in the frontend that isnt implemented in backend, people can bypass it I dont even know if noVideos will be the actual name we use, it's just an example noVideos isnt consistent with requirePostLinkIsMedia maybe it should be postLinkIsNotVideo not sure

to do later