plebnet-dev / website

plebnet.dev website
https://plebnet.dev
MIT License
7 stars 16 forks source link

Store link on plebnet.dev gated behind unsafe warning #89

Closed zachbitcoin closed 7 months ago

zachbitcoin commented 10 months ago

OS: Mac Big Sur Chrome Version 118.0.5993.117 (Official Build) (arm64) No browser extensions.

When clicking the Store button I am prompted with: Screen Shot 2023-11-21 at 6 37 17 AM

bitkarrot commented 9 months ago

which store button, on which page?

zachbitcoin commented 9 months ago

which store button, on which page?

Screen Shot 2023-11-26 at 7 55 23 PM

https://plebnet-dev.printify.me/

bitkarrot commented 9 months ago

Note: possibly add target="_blank" but also rel="noopener noreferrer" , to see if these additions could fix this.

asherp commented 7 months ago

@bitkarrot we updated the site with your suggested modifications, but the error hasn't gone away. any other ideas?

bitkarrot commented 7 months ago

@asherp what does the error look like and on what browsers? is it only on Chrome?

I presume this error only happens on click from the astro website, if you open a new browser with the link and referral does it also happen? I am out of ideas, maybe the Astro discord might have answers? https://discord.gg/astrodotbuild

bitkarrot commented 7 months ago

How about instead of open link we make it redirect?

bliotti commented 7 months ago

@bitkarrot we updated the site with your suggested modifications, but the error hasn't gone away. any other ideas?

I can't reproduce anything either

Bitc0indad commented 7 months ago
Screenshot 2024-01-28 at 8 58 53 AM

On Google Chrome in Incognito mode I'm able to replicate the original issue see image attached.

Bitc0indad commented 7 months ago

Chrome Browser - MacOs

Verification in inspector mode shows the pushed updates to website:

Store

Screenshot 2024-01-28 at 9 00 42 AM
Bitc0indad commented 7 months ago

Firefox Browser - unsafe warning is not prompted

Screenshot 2024-01-28 at 9 31 44 AM
bliotti commented 7 months ago

hmm, I tried chrome on mac incognito mode, clicking on store link from plebnet.dev site, but no warning popped up, I also tried this with enhanced security settings turned on too.

Safe Browsing site status checked out fine. https://transparencyreport.google.com/safe-browsing/search?hl=en

Here's more info about the issue.
https://support.google.com/chrome/answer/99020?hl=en&co=GENIE.Platform%3DDesktop#:~:text=Did%20you%20mean%20%5Bsite%20name,than%20the%20one%20you%20expected.

maybe google needs to index the store's site url.

maybe a redirect would solve this? idk

Bitc0indad commented 7 months ago

Understood we'll look into the redirect instead

bliotti commented 7 months ago

if this is only a minor annoyance, maybe put on back burner. it may solve itself overtime. Up to @bitkarrot

Could grab another subdomain alias for printify? (different than "plebnet-dev") if doable.

For redirects, wouldn't you need a page for it to hit, say plebnet.dev/store and then when that page loads it triggers the redirect to the external site? (I think it's just a html meta element on the page that does this? Maybe changing window.location too, if you have to force it. )

bitkarrot commented 7 months ago

Can't grab another printify domain without the hassle of extra pay per month, extra hassle of maintenance. This is a low cost print on demand plan that does not have the flexibility of a custom domain name.

We already don't have enough hands on board to maintain the current website as you can see there are still a lot of outstanding issues.

it would be best to find a solution on astro instead.

bitkarrot commented 7 months ago

FWIW - oddly i don't see this problem with the link to mempool.space on the resources tab. So clearly this is something we are doing wrong with Astro on Chrome. Maybe compare the link setup between the two and that is where the issue is.

@Bitc0indad @asherp

bliotti commented 7 months ago

mempool link goes to the official mempool.space domain, that's fine.

The issue is only Chrome's. Chrome is trying to protect the user since "plebnet-dev" looks like the domain "plebnet.dev".

bliotti commented 7 months ago

Again I don't how much this is affecting users, I still can't reproduce it. (may want to test this on more browsers and on on mobile ones too)

albeit another solution - not that clean, but use a different site you own that has a page for handling the redirect. Then store link would point to an obviously different named domain but then that page would redirect it to printly. "redirects as a service" lol


Update: I think DNS can do redirects

bitkarrot commented 7 months ago

Even simpler, a Domain level 301 redirect should do it. No page or server needed.