search

pleco-rs / Pleco

A Rust-based re-write of the Stockfish Chess Engine
https://crates.io/crates/pleco
GNU General Public License v3.0
365 stars 37 forks source link

Midgame centipawn conversion is off #149

Closed nicholasfagan closed 1 year ago

nicholasfagan commented 1 year ago

There's likely a typo in the conversion of values to centipawns. Line 76 has self.mg() / PAWN_EG, where it should likely be self.mg() / PAWN_MG.

https://github.com/pleco-rs/Pleco/blob/26d6fbb44d4166081abde0536f2958db7fab4e3f/pleco/src/core/score.rs#L74-L79

chase-manning commented 1 year ago

@nicholasfagan Thanks so much for raising this issue! Has just been fixed in PR: #150