search

plegall / Piwigo-community

11 stars 23 forks source link

Allow themes to override the template #27

Closed tkuther closed 7 years ago

plegall commented 7 years ago

Hi @tkuther I gladly take your pull-request, but keep in mind the work is not done yet on add_photos.tpl : I still have to implement the "quota" feature. I also think the form is not stable yet. I wait for more user feedback to fix bugs!

Maybe you can also tell me what can be made on original add_photos.tpl so that it's fully compatible with Bootstrap themes (and keep compatibility with elegant/modus)

tkuther commented 7 years ago

Hi @plegall

yeah the template has all the code logic in it. That most likely WILL cause trouble if you update the plugin and the theme lags behind.

Anyways, just for fun, I'll port it to bootstrap and send you a diff if you like. Mostly it should be things like adding .btn.btn-.. classes to buttons, .form-control to selects and such.

plegall commented 7 years ago

Mostly it should be things like adding .btn.btn-.. classes to buttons, .form-control to selects and such

maybe for such a complex template, it would be better to add these with javascript or template prefilter.

We can also add "markers" in the original template to make things easier. But yes, send me the "bootstraped version" and we will see what is our best option here :-)