search

plegall / Piwigo-exif_view

4 stars 6 forks source link

Some EXIF Values are non-numerical and cause NOTICE output #3

Open romanf opened 7 years ago

romanf commented 7 years ago

Hi,

During a sync with the exif_view plugin active, I noticed the following problem:

Some EXIF values are non-numerical but still get processed by function exif_key_translation($key, $value) as if they were.

Example: $key="FlashStrength" $value="0/100"

Will produce: Notice: A non well formed numeric value encountered in /data/wwwroot/mybabey.ch/htdocs_secure/gallery2/plugins/exif_view/main.inc.php on line 166

Notice: A non well formed numeric value encountered in /data/wwwroot/mybabey.ch/htdocs_secure/gallery2/plugins/exif_view/main.inc.php on line 172

Notice: A non well formed numeric value encountered in /data/wwwroot/mybabey.ch/htdocs_secure/gallery2/plugins/exif_view/main.inc.php on line 178

Notice: A non well formed numeric value encountered in /data/wwwroot/mybabey.ch/htdocs_secure/gallery2/plugins/exif_view/main.inc.php on line 186

I don't know exactly which pictures produce this. If you tell me how to output the picture-name/-id or something... :)

Thanks Roman

plegall commented 2 years ago

I think I partially fixed the problem with 089a490900ddc2b4d6c1fd17d05fd1ec43edb149

I admit I think this plugin is not the right way to deal with EXIF metadata. See https://github.com/Piwigo/Piwigo/issues/363 : Piwigo should rely on a library (or external tool) dedicated to parsing metadata.