search

plegall / Piwigo-exif_view

4 stars 6 forks source link

Strict compare Flash Key #7

Open FanchTheSystem opened 5 years ago

FanchTheSystem commented 5 years ago

As there is several other exif data beginning with Flash (like FlashStrength or FlashPixVersion which are string)

It should fix:https://github.com/plegall/Piwigo-exif_view/issues/3

If you like, I may submit a full PR to replace all the strpos in the file because it is the same for all other exif value.

For example FocalLength: https://github.com/plegall/Piwigo-exif_view/blob/2e7451327d70b7fa5f9c6aa6ff2016a64771f289/main.inc.php#L232 There is no warning here because FocalLengthIn35mmFilm is check before and return... https://github.com/plegall/Piwigo-exif_view/blob/2e7451327d70b7fa5f9c6aa6ff2016a64771f289/main.inc.php#L227

Merci !

FanchTheSystem commented 5 years ago

bump ! @plegall