Write Keywords Fails

[libengine]

Hi, several keywords written to IPTC Headers get recognised as a single keyword entry. I checked this issue with XnView MP and darktable on Linux.

[libengine]

Piwigo-write_metadata writes all keywords as a single value into IPTC field 2#025, but the keyword field is a multi-value field. There is an entry in the exiftool-FAQ.

Additional information published by photometa.org.

[libengine]

The code here is a bit outdated. I'd like to contribute a patch which fixes #8. Please note that this patch is against Version 2.8a:

136c136
<   $tags = wm_prepare_string($row['tags'], 64);
---
>   $tags = explode(",", $row['tags']);
172,176c172,175
<   
<   if (strlen($tags) > 0)
<   {
<     # 2#025 in iptcparse($imginfo['APP13'])
<     $command.= ' -IPTC:Keywords="'.$tags.'"';
---
> 
>   # 2#025 in iptcparse($imginfo['APP13'])
>   foreach ($tags as $singletag) {
>     $command.= ' -IPTC:Keywords="'.wm_cutString($singletag, 64).'"';
177a177
> 

[jheinitz]

Hello!

Well done! But I still have to add the GPS Tagging code on my own. Can you tell me how to create a pull request and merge my code to solve the issue

1 https://github.com/plegall/Piwigo-write_metadata/issues/1 ?

Kind regards

Jens

2018-07-03 16:31 GMT+02:00 Pierrick Le Gall notifications@github.com:

Closed #8 https://github.com/plegall/Piwigo-write_metadata/issues/8 via 406d45e https://github.com/plegall/Piwigo-write_metadata/commit/406d45e5b5837a9bb0913248eb34e6e5e44cb37e .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/plegall/Piwigo-write_metadata/issues/8#event-1714194379, or mute the thread https://github.com/notifications/unsubscribe-auth/AEkUgouu3tBosFNO1Z7VpOzHzW5feAhaks5uC4A3gaJpZM4Kyk_O .