Closed BalzaniEdoardo closed 6 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@billbrod remember to remove unused figures in src/plenoptic/data.
Attention: Patch coverage is 82.50000%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 86.70%. Comparing base (
8971b43
) to head (0d98e23
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/plenoptic/tools/external.py | 25.00% | 6 Missing :warning: |
src/plenoptic/data/fetch.py | 86.20% | 4 Missing :warning: |
src/plenoptic/tools/data.py | 76.92% | 3 Missing :warning: |
src/plenoptic/data/__init__.py | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've expanded upon Edoardo's changes:
data/
directory at the root of the repo: we can just download those images (used for tests) from the OSFplt.imread
, which will fail)torchvision
not installed, we no longer install it in notebook, but raise an error telling people to install it.src/plenoptic/data
plenoptic.data
, to look more like scipy's: separate method for each image they can load in.
In this PR we address issue #235 and we move osf_download out of tests.