plenoptic-org / plenoptic

Visualize/test models for visual representation by synthesizing images.
https://plenoptic.readthedocs.io/en/latest/
MIT License
57 stars 9 forks source link

235 include example data #252

Closed BalzaniEdoardo closed 6 months ago

BalzaniEdoardo commented 7 months ago

In this PR we address issue #235 and we move osf_download out of tests.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

BalzaniEdoardo commented 6 months ago

@billbrod remember to remove unused figures in src/plenoptic/data.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 82.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.70%. Comparing base (8971b43) to head (0d98e23). Report is 1 commits behind head on main.

Files Patch % Lines
src/plenoptic/tools/external.py 25.00% 6 Missing :warning:
src/plenoptic/data/fetch.py 86.20% 4 Missing :warning:
src/plenoptic/tools/data.py 76.92% 3 Missing :warning:
src/plenoptic/data/__init__.py 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #252 +/- ## ========================================== - Coverage 86.73% 86.70% -0.04% ========================================== Files 35 38 +3 Lines 3325 3392 +67 ========================================== + Hits 2884 2941 +57 - Misses 441 451 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

billbrod commented 6 months ago

I've expanded upon Edoardo's changes: