Closed billbrod closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Files with missing lines | Coverage Δ | |
---|---|---|
...enoptic/simulate/canonical_computations/filters.py | 100.00% <100.00%> (ø) |
|
src/plenoptic/simulate/models/frontend.py | 95.55% <100.00%> (+1.16%) |
:arrow_up: |
src/plenoptic/simulate/models/naive.py | 99.03% <100.00%> (+0.87%) |
:arrow_up: |
src/plenoptic/tools/conv.py | 100.00% <ø> (ø) |
This PR includes some small changes to the FrontEnd models and related code:
std
arg ofgaussian1d
can now be an int, and includes more validationwidth_ratio_limit
fromCenterSurround
, along with clamping behavior. That wasn't working and is only really needed when training the model, which isn't the focus of plenoptic. I think that sort of clamping behavior is better implemented in the training loopwidth_ratio_limit
, as described abovekernel_size
can be an int or tuple of ints (also inLinear
,Gaussian
,CenterSurround
models)kernel_size=31
orkernel_size=(31,31)
same_padding
type annotations to match behaviorCloses #265, #264