Laplacian pyramid - Githubissues

plenoptic-org / plenoptic

Visualize/test models for visual representation by synthesizing images.

https://plenoptic.readthedocs.io/en/latest/

MIT License

61 stars 9 forks source link

Open billbrod opened 3 years ago

billbrod commented 3 years ago

Several changes:

initialization should be updated to python 3 version (super().__init__()).
needs to be more thoroughly tested
uses analysis/synthesis methods, instead of forward (should it have synthesis?)
name should be changed to LaplacianPyramid from Laplacian_Pyramid
can't automatically determine height, should we do that?
our pyrtools implementation has far more options. we don't want any of those do we?

billbrod commented 3 years ago

As part of this, look into nlpd / normalized_laplacian_pyramid as well:

doesn't run on an RGB image (filters expect 1 element in channel dimension)
currently sets dirname at the top of the file (which is unsafe) and grabs parameters from .npy files (should use a state_dict). See how FrontEnd was changed in #73 for an example of how to handle this better

billbrod commented 3 years ago

Could also remove this completely.

billbrod commented 3 years ago

also: automatically determine height