plenti-themes / compendium

https://plenti-themes.github.io/compendium/
Apache License 2.0
3 stars 1 forks source link

Changes for review: Allow unused categories and tags #5

Open jimafisk opened 2 years ago

jimafisk commented 2 years ago

@roobyz I meant to create a PR for this, but I forgot that I was pushing directly to this repo. I made a couple of changes I want you to be aware of:

  1. I updated .gitignore so we're tracking the themes dir: https://github.com/plenti-themes/compendium/commit/fe501df1c3c1fca3679f0b55f78f41c36d926cfb. The hope is that you track theme files with your project instead of using a git submodule. Should clear up confusion like I noted here: https://github.com/jamestagal/edtechdesigner/issues/29#issuecomment-1171708272
  2. There was a bug in the theme where if you created a catgs or tags that wasn't used in posts content that it would break the build as discussed in this issue: https://github.com/jamestagal/edtechdesigner/issues/29. In Ben's case, there was a corresponding posts JSON content source in the project with the same name as every original post in the theme, but the theme was still defining catgs and tags in its content source that were no longer being used (since all the posts in the theme were overridden). I pushed a fix that should allow the build to complete, but it might not ultimately be the way you want to handle this: https://github.com/plenti-themes/compendium/commit/7dd5f507ca8785b83d4bf2ef63cd9125a6a1dc42