plentymarkets / plentymarkets-shopware-connector

plentymarkets shopware connector plugin
http://www.plentymarkets.eu/shopware/
MIT License
30 stars 51 forks source link

fix PriceResponseParser to prevent the import of pseudoprices that ar… #278

Closed jppeter closed 6 years ago

jppeter commented 6 years ago
Q A
issue or Enhancement issue
BC breaks? no
Deprecations? no
Changelog updated? yes
Tests exists and pass? no

What's in this PR?

This PR fixes the PriceResponseParser to prevent the import of pseudoprices that are equal to the usual price

Why?

According to the old logic, it was possible to set a pseudo price equal to or even higher than the normal selling price. For example, this causes the "has pseudoprice" filter to fail to work properly (because the product has a dummy price, but there is no discount)

Checklist