search

plentymarkets / plentymarkets-shopware-connector

plentymarkets shopware connector plugin
http://www.plentymarkets.eu/shopware/
MIT License
30 stars 51 forks source link

shouldn't be float #508

Closed ArvatisJohannes closed 5 years ago

ArvatisJohannes commented 5 years ago

https://github.com/plentymarkets/plentymarkets-shopware-connector/blob/abddbc3a899318e570acb540489110c343a024ca/Adapter/ShopwareAdapter/ResponseParser/OrderItem/OrderItemResponseParser.php#L88

tested with shopware 5.5.10 Screen Shot 2019-08-16 at 17 07 08

kayaArvatis commented 5 years ago

it should be $taxModel = $this->taxRepository->findOneBy(['tax' => (float)$entry['taxRate']]);

ArvatisJohannes commented 5 years ago

fixed with recent pullrequest https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/510