search

pleonasm / bloom-filter

PHP implementation of a bloom filter
BSD 2-Clause "Simplified" License
62 stars 12 forks source link

Finish implementing json serialisation #3

Closed reedy closed 7 years ago

reedy commented 7 years ago

It'd be nice if it worked... :)

https://github.com/pleonasm/bloom-filter/blob/master/src/Pleo/BloomFilter/BloomFilter.php#L113-L116

pleonasm commented 7 years ago

Very true! It's a bit awkward to serialize the data without having some indication of the amount (and type) of hash functions that were also used in the initial creation of the bloom filter.

But... on thinking of it a bit more I might have a solution. I know I haven't touched this in a while but I have some time this week and maybe I'll take a crack at it since someone is interested :) .

pleonasm commented 7 years ago

Closed by b8d98b0 .