search

plepe / OpenStreetBrowser

An application to ‘browse’ the information in the displayed part of the map. Similar to common Wikis and also the main page of http://www.openstreetmap.org the website shows a narrow menu on the left side, most of the page is used for the display of the map. In contrast to most Wikis the menu is not static, but rather the content of the map can be browsed in categories. For the map a special style has been developed (sorry guys, I neither like the default Mapnik nor Osmarender styles), and special overlays are displayed to support the current browsed categories. When you click on an object (either from the list or directly on the map) informations on this object are displayed.
http://www.openstreetbrowser.org
GNU General Public License v3.0
86 stars 20 forks source link

Option to set editor #123

Closed stefanct closed 4 years ago

stefanct commented 4 years ago

I detest ID and would thus prefer to be able to edit via Josm. It would be nice to be able to change the behavior of the edit link available in the popups to facilitate this directly.

plepe commented 4 years ago

Good idea! I jumped right in and implemented that, it will be included in the next release! -> #124

plepe commented 4 years ago

Done. -> https://blog.openstreetbrowser.org/node/78

Feel free to re-open the issue if you have comments!

stefanct commented 4 years ago

I think you broke it somehow? (and btw users cannot re-open issues AFAICT ;)

plepe commented 4 years ago

Thanks for notifying! I already found the problem - it's sleazy coding and babel. It worked in my development environment, but apparently I never tested it in the live system. Babel converts the code and makes it more strict - and I forgot to declare a variable.

See 8d915077b01f4575ee9d04bdaa6449d87eb83739

Fixed. Will be online with the next update (today?).

stefanct commented 4 years ago

Ah, thanks for the fix! I thought I have used/tested it already, but apparently testing is not possible for users without roll-out so I probably had no need to edit via OSB since then and never tested it. :)

It's certainly not necessary but if you see an effortless way to inform reporters about roll-outs of changes that fix their problems (similar to the emails in Debian's bug tracker) that wouldn't happen again. But I doubt that there is a bot for that (only for notifications about commits that close an issue).

plepe commented 4 years ago

The fix is now online!

stefanct commented 4 years ago

LGTM, thx.