plepe / openstreetmap-tag-translations

Translations of OpenStreetMap tags
11 stars 6 forks source link

Memorials #41

Closed Cybereric closed 5 years ago

Cybereric commented 5 years ago

Hello,

Next time, please open a new issue.

Done :-)

Memorial: done - that was quite some work (for several reasons)

Sorry for that ;-)

1st: some use memorial=, others memorial:type=;

2nd: memorial/monument confusion

Yes both are commemorative things. Some are quite "small" (memorials) and monuments are large. No size defined but if we take the classic roman triumph arch (between 19 and 20 m high) I think we could say that something bigger than 15/20 m is a monument (even if it's named memorial of xxx) To sum up : memorials and monuments are separated in OSM by their size Actually there are more than 3000 "monuments" in France. I think less than 10% are well tagged as monuments ! I'll try to launch (at least in France) a huge cleaning. Working on.

I think I have clearly specified the wiki pages on memorials and monuments.

So back to OpenStreetBrowser I see that monuments are recognized Perhaps the whole category should be named "Memorials & monuments" ? And another filter called "Monuments" could take place in the list "Title/Type/Conflict/..." .

3rd: it's hard to find icons. Maybe you can help?)

I'll check this and I'll give you my opinion about icons as a whole.

I added some more memorial=* values for translation.

Thanks a lot ! I think there are problems with some of these values that are not memorials or should not be used (in bold below)

Let's see :

I hope, I didn't miss anything.

No good work ;-)

plepe commented 5 years ago

That's right. I'm planning to add a warning of memorial:type or memorial_type is used.

So back to OpenStreetBrowser I see that monuments are recognized Perhaps the whole category should be named "Memorials & monuments" ?

Done in en and de.

And another filter called "Monuments" could take place in the list "Title/Type/Conflict/..." .

Done. (Called "monument | memorial" - maybe not optimal. Didn't want to add another string).

Values

Thanks for the feedback on the values. I left the synonyms in the queries (e.g. 'plate'), but they are no longer shown in info and filter.

  • obelisk => ok Shouldn't be with the stele it's not the same thing. There's a man made=obelisk too.

It's now a separate filter.

  • vehicule/tank => no It's not a memorial. I don't see why these vehicles are commemorative. If they are historic they should have the tag "historic=yes" or "historic=vehicle", "historic=tank". There's already "locomotive, railway_car, ship, aircraft" values (see the historic objects of the Historic.place map (https://wiki.openstreetmap.org/wiki/Historical_Objects/Map_Properties)

If a ghost_bike is a memorial, why can't a vehicle also be a memorial. Of course it's something different than a war relic, it has to be something which has been erected to remember something (which in the most cases might be wrong).

What's for example with this: https://yadi.sk/i/jHWZqurb3Vwq6H

Of course it could be historic=vehicle, but the way it is arranged looks very commemorative to me ... I wouldn't say this is not a memorial ...

  • flood_mark / highwater_mark => no

You are right. I added this to the "historic" category. I now assume historic=flood_mark for all variants. Also, I added a few translations (flood_mark=*, flood_date).