search

pleshevskiy / sonic-channel

Rust client for sonic search backend
Mozilla Public License 2.0
41 stars 8 forks source link

Async/await support #4

Open tvolk131 opened 3 years ago

tvolk131 commented 3 years ago

I'd love to see non-blocking I/O that works with Tokio! I don't know exactly how this would work under the hood, but I'm happy to look into it if you're interested.

pleshevskiy commented 3 years ago

Hello! Yes, I wanted to take the time to support async. I think it's low task because sonic doesn't support async yet.

GallagherCommaJack commented 3 years ago

i went ahead and implemented it anyway - probably makes sense to put async support behind a feature flag and open a pr? https://github.com/GallagherCommaJack/sonic-channel/commit/5f942565b814c49e67a0b35d45485698f2f2c377

pleshevskiy commented 3 years ago

@GallagherCommaJack Very cool! Thank you for taking the time to do this. It is desirable to put async realization in a separate feature. there will need to be some fine-tuning if sonic gets a real async version, but that's not related to this PR

pleshevskiy commented 2 years ago

I'll start working on it after the #16