n8whnp
commented
7 years ago @vbaranovskiy-plesk, because this is a module that ships with a specific release, we don't do testing of new module code against older versions of WHMCS. There are two broad sets of changes: adding support for using a server module for an addon product and adding support for marketconnect automation. The product addon changes do rely on classes being defined that are not present in earlier versions and if you intend to make a release that supports older versions that code will need to wrap the addon related changes in conditional tests.
The MC changes are not a risk of running on older versions of WHMCS, the functions won't be called as the MC module does not know it can use automation and so those functions simply won't be called. We have not documented what functions are required for becoming a market connect supported module yet, because we want to implement support for a few more services before nailing down an exact API. At that point we will port the existing implementations to the public API and provide a PR w/those changes here.
I'm happy to see these changes go through your testing and look forward to hearing the results.
vbaranovskiy-plesk
@n8whnp thank you for your request and sorry for long delay in replying.
As i understand this code willn't work at WHMCS 7.0 and WHMCS 6+ ? So if we want to save some versions of our module which works at these versions we need to add a some versioning to our module?
Also i didn't find any info in oficial docs about the following functions:
https://developers.whmcs.com/provisioning-modules/supported-functions/
Where we can read about them?
In general i don't have any comments to request, but before merge we should understand what we need to do with old versions. Also our test engineers will check your changes at our test installation (we understand that you already test it for your release, but formally we should check it too).
Thank you again for your request!