Bug fixes

[ximus]

Hello,

I just started using wkpdf. I'm using OSX 10.7

I immediately ran into issue #19. Some quick research led me to uncomment some code in wkpdf to fix the issue. It now works great for me.

Then I noticed I could not disable caching so I fixed that as well.

Cheers, Max

[plessl]

Hi Max

Thanks for these bug fixes. I will have a look at them over the weekend.

Cheers, Christian

On 25.10.2011, at 20:58, ximus wrote:

Hello,

I just started using wkpdf. I'm using OSX 10.7

I immediately ran into issue #19. Some quick research led me to uncomment some code in wkpdf to fix the issue. It now works great for me.

Then I noticed I could not disable caching so I fixed that as well.

Cheers, Max

You can merge this Pull Request by running:

git pull https://github.com/ximus/wkpdf master

Or you can view, comment on it, or merge it online at:

https://github.com/plessl/wkpdf/pull/22

-- Commit Summary --

• Fixes #19
• Fix caching support

-- File Changes --

M lib/commandline_parser.rb (4) M lib/wkpdf.rb (36)

-- Patch Links --

https://github.com/plessl/wkpdf/pull/22.patch https://github.com/plessl/wkpdf/pull/22.diff

Reply to this email directly or view it on GitHub: https://github.com/plessl/wkpdf/pull/22

[plessl]

Hi Max

I just merged your changes, the fix seems to work fine. It is already pushed to github and also rubygems. Thanks a lot for contributing this fix.

However, to my embarassement wkpdf is still not fully functional but still contains a bug in version 0.5.3. When installing the gem and running it, the following error is thrown:

/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems.rb:334:in `bin_path': can't find executable wkpdf for wkpdf-0.5.3-universal-darwin (Gem::Exception)
    from /usr/bin/wkpdf:19

Somehow the wkpdfexecutable in the bin directory seems not to be found.

Any idea what is going wrong?

[ximus]

I sent you a pull request regarding this last issue.