Non-intrusively fix resume behaviour with DSPlayer

plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.

GNU General Public License v2.0

249 stars 124 forks source link

Non-intrusively fix resume behaviour with DSPlayer #256

Closed pannal closed 5 years ago

pannal commented 5 years ago

GHI (If applicable): #189

Description:

This fixes a situation unique to DSPlayer, where the seekOnStart happens with a value of zero almost immediately. The fix is non-intrusive and doesn't change the behaviour for the default video player.

It keeps track of whether a seekOnStart has actually happened (was greater than 0) and keeps the seekOnStart value until it has been applied.

Checklist:

[x] I have based this PR against the develop branch

pannal commented 5 years ago

There still is a minor issue with DSPlayer that I won't address here: keeping the paused state after seeking doesn't work.

garymm commented 5 years ago

Can someone please review this?

ryan-codingintrigue commented 5 years ago

Thanks @pannal - I can confirm that this fixes all resume issues on my DSPlayer 🎉

This should definitely be merged if possible

ruuk commented 5 years ago

Thanks!