plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.
GNU General Public License v2.0
251 stars 124 forks source link

Collection and folder #275

Open gbooker opened 5 years ago

gbooker commented 5 years ago

GHI (If applicable): None

Description:

Allow browsing movies by collection and by folder. Useful for a large movie library and a library where there is no metadata and items are arranged on the server by folder.

Checklist:

pannal commented 5 years ago

Hey, I've been testing this PR; it seems to fail reproducably.

When entering an empty folder (in my case a "subs" folder that doesn't return any children whatsoever) inside a valid folder, then going back up again until the main library view is hit, then opening any item results in an empty view.

pannal commented 5 years ago

OK, this is a pretty easy fix:

Index: lib/windows/library.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- lib/windows/library.py  (revision ea1b1bc138ce7f45803dc6bd08c7b0b06c34f4c5)
+++ lib/windows/library.py  (revision e1b05f65fd38c4b4399e2a0a928cc51d00157462)
@@ -1219,7 +1219,7 @@
                 self.librarySettings.setItemType(self.librarySettings.getItemType())
             else:
                 self.processCommand(opener.handleOpen(preplay.PrePlayWindow, video=datasource, parent_list=self.showPanelControl))
-            updateWatched = True
+                updateWatched = True
         elif self.section.TYPE == 'artist':
             if ITEM_TYPE == 'album':
                 self.openItem(mli.dataSource)
@@ -1652,7 +1652,7 @@
                             if not obj.isDirectory():
                                 mli.setLabel2(util.durationToText(obj.fixedDuration()))
                             mli.setProperty('art', obj.defaultArt.asTranscodedImageURL(*artDim))
-                            if not obj.isWatched:
+                            if not obj.isWatched and obj.TYPE != "Directory":
                                 if self.section.TYPE == 'show':
                                     mli.setProperty('unwatched.count', str(obj.unViewedLeafCount))
                                 else: