Kodi 19/Python 3 compatibility

plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.

GNU General Public License v2.0

249 stars 124 forks source link

Kodi 19/Python 3 compatibility #294

Closed pannal closed 4 years ago

pannal commented 4 years ago

GHI (If applicable): #

Description:

Kodi 19 drops Python 2 in favor of Python 3. This uses kodi.six and the six module, as well as a couple of compatibility changes in the code, to be backwards compatible with Kodi 18 and Python 3 compatible.

Checklist:

[x] I have based this PR against the develop branch

ruuk commented 4 years ago

You can probably drop that last commit and rebase (since I committed a 'proper' fix). I'll try to review and test this soon.

pannal commented 4 years ago

Ah, this isn't backwards compatible with Kodi 18 anymore btw. They fully dropped Py2 support.

ruuk commented 4 years ago

The python 3 compatibility PR #307 (Kodi 18) has been merged. I'll maintain the develop-kodi19 branch which is simply the develop branch with a single commit for the addon.xml version changes that I can just keep rebased and use to submit for Kodi 19 in addition to the normal submission.

Thanks for the compatibility work! I really appreciate it.