plexinc / plex-for-kodi

Offical Plex for Kodi add-on releases.
GNU General Public License v2.0
249 stars 124 forks source link

playback speed #297

Closed worldjoe closed 4 years ago

worldjoe commented 4 years ago

GHI (If applicable): #296

Description: Playback speed icons. These come from Kodi's confluence skin, which is GPL2. I believe @HitcherUK originally created most of these icons. I created (poorly) a few that were missing for speeds that I enjoy (up to 2.0).

Checklist:

worldjoe commented 4 years ago

This pull request does very little by itself. All it does is show the playback speed icon. It does not lalow for changing the playback speed. Users will still need to enable that feature for themselves. See more here: https://forums.plex.tv/t/playback-speed/69044/147 In particular, users will still need to upload their custom keymap to change fast forward/rewind buttons on their remote to trigger playback speed. And users will need to upload a custom advancedsettings.xml file if they want to enable 1.6 thru 2.0 speeds.

ruuk commented 4 years ago

Thanks for the PR, but closing it as I've implemented it differently.

I've added a simple text display under the current playback time, both to eliminate the need for images and increase in addon size, and to allow handling any speed without needing to add more images.

skoshy commented 3 years ago

Thanks for the PR, but closing it as I've implemented it differently.

I've added a simple text display under the current playback time, both to eliminate the need for images and increase in addon size, and to allow handling any speed without needing to add more images.

Is this currently live? I'm trying to change the playback speed in Plex on Kodi on my Android TV and can't find this text display.

worldjoe commented 3 years ago

Is this currently live? I'm trying to change the playback speed in Plex on Kodi on my Android TV and can't find this text display.

Any release 0.2.1 or above will have this feature. The change was merged here: https://github.com/plexinc/plex-for-kodi/commit/680fc4f3e164dea7de615e07b517a8ee04f158d7